Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsl.MotionOutliers output spec no longer requires out_file to exist #1428

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

beausievers
Copy link
Contributor

fsl.MotionOutliers output spec no longer requires out_file to exist. fsl_motion_outliers does not create an output file when no timepoints are above the threshold, and in this situation fsl.MotionOutliers would throw a FileNotFoundError. This pull request fixes that immediate problem.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.538% when pulling 95b4fc8 on beausievers:master into 4b392d5 on nipy:master.

@satra
Copy link
Member

satra commented Apr 12, 2016

@oesteban, @chrisfilo - we need to come up with a reasonable solution before this release. turns out the file is not created when the threshold does not result in any outliers. i was going to write a list outputs for this interface, but do you think we could have the following pattern.

if metadata exists does not exist
   and file pattern created by name_template does not match an existing file
then keep output undefined

oesteban added a commit to oesteban/nipype that referenced this pull request Sep 20, 2016
@mgxd
Copy link
Member

mgxd commented Apr 4, 2017

@satra @oesteban has this been solved or should we merge this? related to #1427

@effigies
Copy link
Member

exists=True is a blight in output specs. I'm merging regardless.

@effigies effigies merged commit e07301d into nipy:master Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants