add custom_info to group_dicoms_into_seqinfos call in parser

[bpinsard]

No description provided.

[yarikoptic]

are you trying to take over (which would be welcome to help bringing it over the finish line) the #581?

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (enh-custom-seqinfo@00f8b56). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@                  Coverage Diff                  @@
##             enh-custom-seqinfo     #637   +/-   ##
=====================================================
  Coverage                      ?   81.35%           
=====================================================
  Files                         ?       42           
  Lines                         ?     3840           
  Branches                      ?        0           
=====================================================
  Hits                          ?     3124           
  Misses                        ?      716           
  Partials                      ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[bpinsard]

Didn't meant to take over, just to influence the PR to include what makes it work for us. :-)

Just added commits that should get the tests passing.
The main constraint for the custom_seqinfo is that is needs to be hashable: that is likely be an error people using that function will run into, so it will need to be clearly documented. Or maybe should we add a check on the return value in the code with a more explicit error message?

[yarikoptic]

Didn't meant to take over,

if you can/want -- please do!

The main constraint for the custom_seqinfo is that is needs to be hashable: that is likely be an error people using that function will run into, so it will need to be clearly documented. Or maybe should we add a check on the return value in the code with a more explicit error message?

Good point/aspect. The more checks to puke as early as possible the better instead of delaying inevitable crash with obscure error.

[yarikoptic]

Suggested change

	If present this function will be called on eacg group of dicoms with
	If present this function will be called on each group of dicoms with

we have codespell workflow which should pickup typos. If you rebase -- we better see it working on this PR too (for some reason it did not even though I think it was back 2 weeks ago when you started this PR)

[yarikoptic]

oh, this is PR to my PR -- I will take it on and then rebase my PR. Thanks!

[yarikoptic]

I have fasfforwaded my branch to these changes (thanks @bpinsard ), then fixed up for my suggestions, rebased and force pushed in my PR (#581). because of rebase github did not figure out to close this PR. Let's continue from that newer state