fixes semi-regression; discard check now skips nkHiddenSubConv (#23840

) follow up #23681 ref https://forum.nim-lang.org/t/11987 (cherry picked from commit 648f82c)
nim-lang · Aug 31, 2024 · 568a637 · 568a637
1 parent 8b421d2
commit 568a637
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/compiler/semstmts.nim b/compiler/semstmts.nim
@@ -132,7 +132,7 @@ const
   skipForDiscardable = {nkStmtList, nkStmtListExpr,
     nkOfBranch, nkElse, nkFinally, nkExceptBranch,
     nkElifBranch, nkElifExpr, nkElseExpr, nkBlockStmt, nkBlockExpr,
-    nkHiddenStdConv, nkHiddenDeref}
+    nkHiddenStdConv, nkHiddenSubConv, nkHiddenDeref}
 
 proc implicitlyDiscardable(n: PNode): bool =
   # same traversal as endsInNoReturn

diff --git a/tests/discard/tdiscardable.nim b/tests/discard/tdiscardable.nim
@@ -140,3 +140,12 @@ block: # issue #14665
         continue
       inc i
   test()
+
+block:
+  proc test(): (int, int) {.discardable.} =
+    discard
+
+  if true:
+    test()
+  else:
+    quit()