Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support run in child_process #87

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Feb 21, 2025

Fixes #86

Prettier PR prettier/prettier#17131

error => void onFailure(test, error),
),
test => {
onStart(test);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this done for the same problem as #81?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in #86, I don't think it's possible to use MessageChannel, so I just call onStart and use p-map to run tests concurrently. Everything seems good when I run this in Prettier. I'm not sure #81 should use this solution too, but it's out scope of this one.

@fisker fisker marked this pull request as ready for review February 21, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support run in child_process
2 participants