Skip to content

Commit

Permalink
Reintroduce default value for ignore_args argument of FixtureManager.…
Browse files Browse the repository at this point in the history
…getfixtureclosure

Fix pytest-dev#11868
  • Loading branch information
nicoddemus committed Jan 30, 2024
1 parent cb57bf5 commit 571e506
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelog/11868.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Reintroduced the default value for the ``ignore_args`` of internal ``FixtureManager.getfixtureclosure``: even though it is an internal API, it was changed by accident in 8.0.0 and this broken a number of plugins.
2 changes: 1 addition & 1 deletion src/_pytest/fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -1524,7 +1524,7 @@ def getfixtureclosure(
self,
parentnode: nodes.Node,
initialnames: Tuple[str, ...],
ignore_args: AbstractSet[str],
ignore_args: AbstractSet[str] = frozenset(),
) -> Tuple[List[str], Dict[str, Sequence[FixtureDef[Any]]]]:
# Collect the closure of all fixtures, starting with the given
# fixturenames as the initial set. As we have to visit all
Expand Down

1 comment on commit 571e506

@cjw296
Copy link

@cjw296 cjw296 commented on 571e506 Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly for Sybil, this wasn't sufficient:

simplistix/sybil@429ed42

Please sign in to comment.