Skip to content

use @aws-cdk/cloudformation-diff for diff generation #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AndrewChubatiuk
Copy link

@AndrewChubatiuk AndrewChubatiuk commented Dec 6, 2022

Hi @nicka and @dougmoscrop
Thank you for a project. I've replaced json-diff with aws-cdk/cloudformation-diff to make visualisation more clear and upgraded some packages. I've published it as serverless-diff-plugin. Please let me know if you are okay with these changes

  • replaced json-diff with @aws-cdk/cloudformation-diff
  • added custom.diff.tableWidth (or DIFF_TABLE_WIDTH env variable) parameter to control IAM diff table width (useful for CI log output)
  • generate diff even if there's no cloudformation template deployed
  • upgraded old and deprecated dependencies
  • package is being triggered automatically during diff command execution
  • added custom.diff.excludes key to exclude some results from diff using jsonpath
  • added custom.diff.reportPath key for gitlabci tfplan report generation

@bm1549
Copy link

bm1549 commented Jan 30, 2023

This is amazing!

@AndrewChubatiuk
Copy link
Author

AndrewChubatiuk commented Jan 30, 2023

@bm1549 thanks
I’m currently supporting my fork. You can check it

@mrchops1024
Copy link

@AndrewChubatiuk Are you still maintaining your fork? It looks like everything I've been wanting from this repo, but I can't get the diff working. It seems to always show a diff as if no resources have been deployed.

@AndrewChubatiuk
Copy link
Author

@mrchops1024 yes, still maintaining. I've enabled issues in a fork. Can you post a problem with configuration you're using?

@MartinLoeper
Copy link

Awesome work @AndrewChubatiuk!

@mrchops1024
Copy link

@mrchops1024 yes, still maintaining. I've enabled issues in a fork. Can you post a problem with configuration you're using?

@AndrewChubatiuk - I raised an issue in your fork but haven't seen any response. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants