feat: add deriveLoading RxJs-Operator #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mikelgo - Could you please raise an issue with details for the use case and a brief example of how to use it? This initially looked similar to #56 & #354, but the tests helped clarify things. |
Issue created: #440 |
|
Let me know if I need to do anything. I saw that CI was failing (however not sure why). |
nartc
approved these changes
Jul 15, 2024
|
Nice 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a
deriveLoadingRxJs Operator which will emit a loading state/ boolean flag based on some underlying async operation. This will also be done in a "non-flickering" way.I'm not sure where I can add some documentation for this.
Looking forward to your feedback, probably also we can find a better name. I'm not completely happy.