feat(to-observable-signal): refactor toObservableSignal to handle Obs… #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervables and Subscribables The refactor allows toObservableSignal to handle Observables and Subscribables, expanding its flexibility and usage. It introduces the ability to convert an Observable or Subscribable to a Signal & Observable, enhancing its adaptability. This change aims to improve the overall functionality of toObservableSignal by broadening its capabilities.
nartc
reviewed
Jun 10, 2024
libs/ngxtension/to-observable-signal/src/to-observable-signal.ts
Outdated
Show resolved
Hide resolved
libs/ngxtension/to-observable-signal/src/to-observable-signal.ts
Outdated
Show resolved
Hide resolved
|
@all-contributors please add @nguyenphutrong for code |
|
I've put up a pull request to add @nguyenphutrong! 🎉 |
nartc
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ervables and Subscribables
The refactor allows toObservableSignal to handle Observables and Subscribables, expanding its flexibility and usage. It introduces the ability to convert an Observable or Subscribable to a Signal & Observable, enhancing its adaptability. This change aims to improve the overall functionality of toObservableSignal by broadening its capabilities.