Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reintroduce computedAsync which reexports and shows a deprecatio… #342

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

eneajaho
Copy link
Collaborator

@eneajaho eneajaho commented Apr 24, 2024

…n notice

We need to release this in a patch I guess. And then I will remove it using the Breaking Changes flag and we can release a major.

@Sergiobop
Copy link

Thanks!

Btw @eneajaho, when i updated to 2.3 this popped up:
An unhandled exception occurred: Schematic "rename-computed" is missing a factory.

@eneajaho
Copy link
Collaborator Author

Thanks!

Btw @eneajaho, when i updated to 2.3 this popped up: An unhandled exception occurred: Schematic "rename-computed" is missing a factory.

Are you inside nx monorepo or normal angular app?

@Sergiobop
Copy link

Thanks!
Btw @eneajaho, when i updated to 2.3 this popped up: An unhandled exception occurred: Schematic "rename-computed" is missing a factory.

Are you inside nx monorepo or normal angular app?

Normal app:

Angular CLI: 17.3.5
Node: 20.11.0
Package Manager: npm 10.5.2
OS: darwin x64

Angular: 17.3.5
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, material, material-moment-adapter, platform-browser
... platform-browser-dynamic, router, service-worker
... youtube-player

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1703.5
@angular-devkit/build-angular   17.3.5
@angular-devkit/core            17.3.5
@angular-devkit/schematics      17.3.5
@schematics/angular             17.3.5
rxjs                            7.8.1
typescript                      5.4.5
zone.js                         0.14.4

@eneajaho
Copy link
Collaborator Author

Thanks!
Btw @eneajaho, when i updated to 2.3 this popped up: An unhandled exception occurred: Schematic "rename-computed" is missing a factory.

Are you inside nx monorepo or normal angular app?

Normal app:

Angular CLI: 17.3.5
Node: 20.11.0
Package Manager: npm 10.5.2
OS: darwin x64

Angular: 17.3.5
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, material, material-moment-adapter, platform-browser
... platform-browser-dynamic, router, service-worker
... youtube-player

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1703.5
@angular-devkit/build-angular   17.3.5
@angular-devkit/core            17.3.5
@angular-devkit/schematics      17.3.5
@schematics/angular             17.3.5
rxjs                            7.8.1
typescript                      5.4.5
zone.js                         0.14.4

This PR #345 should solve the issue 🙌

@eneajaho eneajaho enabled auto-merge (squash) April 24, 2024 12:03
@Sergiobop
Copy link

You are the best @eneajaho

Thanks

@eneajaho eneajaho merged commit 3de9e09 into main Apr 24, 2024
1 check passed
@eneajaho eneajaho deleted the fix/computedAsync-revert branch April 24, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants