Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(convert-signal-inputs): handle automatic semicolon insertion issues #294

Merged

Conversation

joshuamorony
Copy link
Contributor

fixes #290

Due to Automatic Semicolon Insertion this is valid JS/TS syntax:

@Component({})
export class MyCmp {
  @Input() inputWithoutType;
  noColon = true
}

But when processing property declarations this can mess with ts-morph since ASI has not been applied. This PR catches errors arising from this situation and warns to attempt fixing it and trying again.

Copy link

nx-cloud bot commented Mar 1, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ee3bccf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@eneajaho eneajaho force-pushed the fix/convert-signal-inputs-iterator branch from 85d99c9 to ee3bccf Compare March 23, 2024 23:31
@eneajaho eneajaho merged commit 09f075d into ngxtension:main Mar 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert-signal-inputs fails
2 participants