Pass the entire slice to selectors function

[robbaman]

Changed the selector definition to be the entire signalSlice as oposed to just the state.

Not sure how to run the tests (the docs just say to 'run the tests'), so not sure if this also required a change to the test framework. The changed version did do what I'd expect in my project.

[joshuamorony]

Note to reviewers this was discussed/agreed in this issue: #187

@robbaman you can run the tests with pnpm exec nx run ngxtension/signal-slice:test, this likely will not break any existing tests but ideally it would be good to add an extra test where one of the top level selectors is accessed to create a custom selector

[robbaman]

It seems while this change does work in runtime it does in fact break a test because of a TypeScript compiler flag.

This error can be suppressed by setting noPropertyAccessFromIndexSignature to false in the tsconfig.json file, but I'm not sure if that's the direction you'd want to go with the project.

[joshuamorony]

You should be able to solve this by passing in any instead of TSelectors when typing the selectors config:

	selectors?: (
		state: SignalSlice<
			TSignalValue,
			TActionSources,
			any,
			TEffects,
			TActionEffects
		>
	) => TSelectors;

[joshuamorony]

With the typing change I think we will then just need a test to verify the new functionality and we should be good to merge

[joshuamorony]

Suggested change

	selectors?: (
	state: SignalSlice<
	TSignalValue,
	TActionSources,
	TSelectors,
	any,
	TActionEffects
	>
	) => TSelectors;
	selectors?: (
	state: SignalSlice<
	TSignalValue,
	TActionSources,
	any,
	TEffects,
	TActionEffects
	>
	) => TSelectors;

[robbaman]

You're correct. I've made the change and also changed the test file to read the age property from state().age to state.age() to confirm it is indeed the entire slice that is provided.

[joshuamorony]

LGTM, thanks!

Will just need to wait on a reviewer with write access to trigger the workflow and get this merged

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5ee21f4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

⌛ The following target is in progress

• nx affected --target=build --parallel=3 --exclude=docs

✅ Successfully ran 3 targets

• nx affected --target=test --parallel=3 --ci --code-coverage
• nx affected --target=lint --parallel=3
• nx-cloud record -- pnpm exec nx format:check

---

Sent with 💌 from NxCloud.

[nartc]

@all-contributors please add @robbaman for code

[allcontributors]

@nartc

I've put up a pull request to add @robbaman! 🎉