Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular 19 compatibility #213

Closed
Schoude opened this issue Nov 25, 2024 · 2 comments · Fixed by #215
Closed

Angular 19 compatibility #213

Schoude opened this issue Nov 25, 2024 · 2 comments · Fixed by #215
Labels
bug Something isn't working

Comments

@Schoude
Copy link

Schoude commented Nov 25, 2024 •
edited
Loading

Describe the bug

Can't install this package in Angular 19 project.

To Reproduce

Run npm install @ngworker/lumberjack for an Angular 19 project.

Expected behavior

Should be able to install without using npm install --force.

Environment

  • OS: Windows 10
  • Lumberjack Version 18.0.0
  • Angular version: 19.0.0
@Schoude Schoude added the bug Something isn't working label Nov 25, 2024
@NachoVazquez
Copy link
Contributor

Yep, we haven't yet migrated the package to Angular 19. I'll try to do it tonight.

@NachoVazquez NachoVazquez mentioned this issue Nov 26, 2024
Merged
3 tasks
NachoVazquez added a commit that referenced this issue Nov 26, 2024
@NachoVazquez
feat!: update to the latest nx (#215)
762206f 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] The commit message follows our guidelines: CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

```
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
```

## What is the current behavior?

We support the previous version of Angular (18)

Closes: #213 

## What is the new behavior?

Migrate to the latest Angular and Nx.

## Does this PR introduce a breaking change?

```
[x] Yes
[ ] No
```

BREAKING CHANGES:

Only support Angular version 19
@NachoVazquez
Copy link
Contributor

@Schoude a new version has been released with support for Angular 19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: update to the latest nx ngworker/lumberjack
2 participants
@NachoVazquez @Schoude