Implementation of PKCE authentification #191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version of ARCitect client ids and secrets have to be stored in code. It would be nice to avoid storing the secrets in code. This can be avoided by using PKCE flow. Here I implemented this in DataHubService.ts.
The PKCE will be used if a datahub entry in Credentials does not contain a "secret" field.:
The previous authentification method is still possible
pkce will only work if confidential is turned off - and I assume that then client_id/ client_secret method will not work anymore.
Not thouroughly tested. But from receving the token/refresh token everything should be the same as before.