Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace editorconfig by pre-commit-hooks #3467

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

mirpedrol
Copy link
Member

remove editorconfig and replace it by pre-commit-hooks to allow formatting (editorconfig lints but it doesn't format the files)

.*\.snap$|
nf_core/pipeline-template/subworkflows/.*|
nf_core/pipeline-template/modules/.*|
tests/pipelines/__snapshots__/.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we need to also exclude main.nf in modules and subworkflow template files

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think modifying the template is good, no? What we should skip are the modules and subworkflows because they are handeled in the module repo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am just wondering about the introduced changes... how come they were not there with editorconfig?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see anywhere where we excluded these files... but I have tested creating a new pipeline and running pre-commit there and everything passes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, fine for me then. 🙂

@mirpedrol mirpedrol merged commit c2a4a0d into nf-core:dev Feb 25, 2025
94 checks passed
@mirpedrol mirpedrol deleted the no-editorconfig branch February 25, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants