Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runner.docker: Initial, minimal setup support #222

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

tsibley
Copy link
Member

@tsibley tsibley commented Oct 6, 2022

Downloads the image if it's not already available locally, avoiding an awkward download on first use. It makes more sense to do this in setup than to advise folks to run update after install. The update machinery is still used behind the scenes.

Diff best viewed with whitespace ignored.

Testing

  • CI passes, though why wouldn't it?
  • Locally tested by hand

Downloads the image if it's not already available locally, avoiding an
awkward download on first use.  It makes more sense to do this in
`setup` than to advise folks to run `update` after install.  The update
machinery is still used behind the scenes.

Diff best viewed with whitespace ignored.
@tsibley tsibley requested a review from a team October 6, 2022 22:44
Copy link
Member

@victorlin victorlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • nextstrain setup docker looks good
  • nextstrain setup docker --force looks good
  • nextstrain setup docker --dry-run looks good

@tsibley tsibley merged commit b9dde8c into master Oct 12, 2022
@tsibley tsibley deleted the trs/docker/setup-download-image branch October 12, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants