runner.docker: Distinguish between an explicit vs. implicit "latest" image tag when updating #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now prunes images older than the just-updated-to image, not the just-updated-from image. This bug meant that pruning would find older images from *past* updates but skip the old image it just updated from, i.e. if image N is the image just updated to, then images N-2 and older were pruned instead of images N-1 and older. An off-by-one bug, of a sort. I'd noticed this behaviour many times but had thought it was something about the pruning causing other images to become prune-able (and thus picked up in subsequent `nextstrain update` runs). It was only when I tried to fix that understanding of the bug with a loop and it didn't work that I realized during debugging what was happening.
…image tag when updating Behaviour with an implicit "latest" tag remains the same: it resolves to the most recent "build-*" tag when `nextstrain update` is run which then pins it in the config file. An explicit "latest" tag used to do the same but now is preserved: it's not updated to the most recent "build-*" tag during `nextstrain update`. This allows folks to opt into tracking the leading edge of changes to the image. Resolves <#96>.
This was referenced Apr 1, 2022
joverlee521
approved these changes
Apr 7, 2022
|
Released in 3.2.4 just now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Behaviour with an implicit "latest" tag remains the same: it resolves to
the most recent "build-*" tag when
nextstrain updateis run which thenpins it in the config file.
An explicit "latest" tag used to do the same but now is preserved: it's
not updated to the most recent "build-*" tag during
nextstrain update.This allows folks to opt into tracking the leading edge of changes to
the image.
Resolves #96.
Testing
Tested locally and works for me. Also added additional doctests.