runner.docker: Avoid merging stdout and stderr together #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Further conditionalizes the use of --tty for `docker run` so that the container process' stdout and stderr aren't merged when the user of `nextstrain` wishes to redirect one or both of them elsewhere. Resolves #152.
victorlin
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further conditionalizes the use of --tty for
docker runso that thecontainer process' stdout and stderr aren't merged when the user of
nextstrainwishes to redirect one or both of them elsewhere.Resolves #152.
Testing
Tested with manual invocations in many permutations to ensure output remains separated. I wanted to write some Cram tests to prevent regressions, but this turns out to be difficult as Cram itself needs to redirect stdout/stderr of the test file's commands in order to do its own job. Maybe later I'll sort that out…