Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple independent extensions #94

Closed
michaljurecko opened this issue Jan 17, 2019 · 1 comment
Closed

Allow multiple independent extensions #94

michaljurecko opened this issue Jan 17, 2019 · 1 comment

Comments

@michaljurecko
Copy link

michaljurecko commented Jan 17, 2019

Hi,

Branch/commit: master - 5970edad7945214a3eb5e22f74caa1cd35303b4d.

I registered extension twice in my config.neon.
Each instance for separated database, with separated migrations dir.
And it was working with some 3.0@dev version.

Now I try to update to 3.1@dev version.
But migrations (dirs / Nextras\Migrations\Entities\Group) from each separated extension are mixed together. In each configuration (generated by extension) are present all groups.

Reason is probably in MigrationsExtension::createConfigurationDefinition.
It creates Nextras\Migrations\Configurations\Configuration with autowired constructor paramaterGroup[] $groups.

The solution would be to provide constructor parameters of Configuration directly without autoloading.

Version v3.1.0-rc2 is working.

@o5
Copy link
Contributor

o5 commented Apr 23, 2020

@Webrouse Did you use it with Symfony Command? How about console commands name prefix? https://github.com/nextras/migrations/blob/master/src/Bridges/SymfonyConsole/ContinueCommand.php#L20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants