-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ubuntu 22.04 as default SKU for Azure Batch #5804
Conversation
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Docs need to be updated here |
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Well spotted
…On Thu, Feb 20, 2025 at 2:25 PM Ben Sherman ***@***.***> wrote:
Docs need to be updated here
<https://nextflow.io/docs/latest/azure.html#pool-nodes>
—
Reply to this email directly, view it on GitHub
<#5804 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGHOSG6SQMIMWPW2MRRRP32QXJVHAVCNFSM6AAAAABXQXQ5MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZRGQ4TMOBQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: bentsherman]*bentsherman* left a comment
(nextflow-io/nextflow#5804)
<#5804 (comment)>
Docs need to be updated here
<https://nextflow.io/docs/latest/azure.html#pool-nodes>
—
Reply to this email directly, view it on GitHub
<#5804 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGHOSG6SQMIMWPW2MRRRP32QXJVHAVCNFSM6AAAAABXQXQ5MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZRGQ4TMOBQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@adamrtalbot happy with this? |
Just needed to correct the docs: ad7634e |
Wait hold on, I get an error:
|
umm, how tests are passing?! |
There is no Azure Batch ubuntu-2204 image 🤦 I think we need to use the DSVM replacement.
Microsoft just do a "latest supported" tag :shakefist: |
A more recent alternative would be this:
Will give it a try. |
Did not work - DSVM it is (which comes with GPU drivers and stuff so might be better anyway). |
Deprecation notes mention
|
Ok so 2e69a40 is correct |
Can you revert and revert and test it? |
You mean rollback to 192699b? There isn't a 22.04 image so this doesn't work. Or do you want me to test the CI? |
I've tried:
It tries to create the pool, but then it fails with:
Not sure what to do |
That's a very old VM size which isn't a generation 2 VM, so it doesn't support the virtual machine image. It's been deprecated now so you should switch to something like a Dsv6 machine. Note: you'll need to make sure you have quota in the CI batch account. |
Can you suggest one in concrete? |
Let's go with a Standard_D4_v5, cheap and should be widely available. |
Hanging with this error message when creating the pool I see two problems, 1) it should not hang on pool creation errors, 2) still unable to find a valid default instance type for ubuntu. If you could give a try to address at least the latter it would be appreciated. |
We need to make sure there is sufficient quota in the Batch account. Which Batch account is it running in? We can either increase the quota or use a machine with quota available. Note spot machines have their own generic quota for all machine types, so this might be an option. p.s. there is one alternative which is much, much more complicated but consistent with AWS/Google. |
Regarding this:
Yeah it sucks, Azure node pools are detached from running so I don't know whether we can catch it in Nextflow. Seqera Platform should be able to check the pool is in active state though. |
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
2e69a40
to
8cd7f3f
Compare
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Co-authored-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
This PR bumps Ubuntu 22.04 as default SKU for Azure Batch node pools. This is required because Ubuntu 20.04 is going to be retired by April 2025 (See below):