Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add --no-upgrade option to skip calling occ upgrade after update #460

Merged
merged 2 commits into from
Feb 7, 2023
Merged

feat: Add --no-upgrade option to skip calling occ upgrade after update #460

merged 2 commits into from
Feb 7, 2023

Conversation

tcitworld
Copy link
Member

This can be useful in scenarios running non-interactively but wanting to do both things separately

@tcitworld tcitworld added this to the Nextcloud 26 milestone Feb 3, 2023
@tcitworld
Copy link
Member Author

Building the phar package seems to update other composer autoloading files as well, so it probably won't pass tests.

@come-nc
Copy link
Collaborator

come-nc commented Feb 6, 2023

Building the phar package seems to update other composer autoloading files as well, so it probably won't pass tests.

Confirmed, but how do we fix that? It’s a composer version problem?

@tcitworld
Copy link
Member Author

tcitworld commented Feb 6, 2023 •
edited
Loading

Yup, composer dump-autoload gives a different output. You could run make updater.phar in another PR to update the vendor contents and the phar file done in #461, then I'll rebase and build here.

Also tests are locked to PHP7.4 which no longer with Nextcloud master. #462

@tcitworld tcitworld mentioned this pull request Feb 6, 2023
Merged
@tcitworld
feat: Add --no-upgrade option to skip calling occ upgrade after update
3510e62 
This can be useful in scenarios running non-interactively but wanting to do both things separately

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld force-pushed the add-no-upgrade-option branch 2 times, most recently from ecdb366 to 1f936fc Compare February 7, 2023 13:45
@tcitworld
Run make updater.phar again
08a8f7b 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld force-pushed the add-no-upgrade-option branch from 1f936fc to 08a8f7b Compare February 7, 2023 13:50
@blizzz blizzz merged commit f3afb79 into master Feb 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-no-upgrade-option branch February 7, 2023 14:36
@blizzz blizzz mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@come-nc come-nc come-nc approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
3. to review enhancement
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
3 participants
@tcitworld @come-nc @blizzz