[stable26] fix(sync): push local changes on reconnect #5286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
mejo-
force-pushed
the
backport/5279/stable26
branch
3 times, most recently
from
b4947f8 to
da3fcaf
Compare
3 flaky tests on run #12457 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync > saves the actual file and document state |
Screenshots
|
|
| Sync > saves on close |
Screenshots
|
|
| Sync > passes the doc content from one session to the next |
Screenshots
|
|
Review all test suite changes for PR #5286 ↗︎
When an editing session is interrupted steps that were already pushed to the server may be cleared alongside the sync service session. Make sure to push all local state that is not part of the document state when (re-)connecting. Tests Yjs relies on a browser environment. Therefore we test it in a cypress test. Move these tests into component tests to separate them from 'normal' e2e tests. Signed-off-by: Max <max@nextcloud.com>
Even if all sessions have expired and been removed there may still be disconnected clients that hold state from the last editing session. When they reconnect they will send their yjs updates based on the old state they had. Preserve the yjs state accross editing sessions so updates send after a reconnect can still be processed. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Remove duplicate encoding for updateMessage Signed-off-by: Max <max@nextcloud.com> Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
mejo-
force-pushed
the
backport/5279/stable26
branch
from
579cc96 to
59e5c9c
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
mejo-
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5279
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
[skip ci]tagLearn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.