Adjust smart picker menu action #4063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
julien-nc
commented
Apr 17, 2023
•
julien-nc
commented
- Adjust the menu item label
- Adjust the icon to use the same as in Mail
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
added
design
julien-nc
requested review from
juliusknorr,
mejo-,
luka-nextcloud and
max-nextcloud
|
IMO this can be backported to stable26 but this is not a bug fix... |
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/smart-picker-menu-action-label
branch
from
5750b9d to
ded5e02
Compare
|
/compile |
julien-nc
changed the title
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
3 flaky tests on run #9429 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync > recovers from a lost connection |
Output
Screenshots
|
|
conflict.spec.js • 2 flaky tests
| Test | Artifacts | |
|---|---|---|
| Open test.md in viewer > resolves conflict using current editing session |
Output
Screenshots
|
|
| Open test.md in viewer > resolves conflict using server version |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
max-nextcloud
approved these changes
Apr 17, 2023
|
/backport to stable26 |
I'll create a backport request. Stable26 is blocked for most of the week anyway and we can discuss if we want to backport in the backport PR. |
delete-merged-branch
bot
deleted the
enh/noid/smart-picker-menu-action-label
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.