fix: collaborator disconnect timeout #3769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max <max@nextcloud.com>
|
/compile |
|
Even though this improves the behavior of the |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
1 flaky tests on run #8496 ↗︎
Details:
|
|||||||||||||||||||||
| Test | ||
|---|---|---|
| Open test.md in viewer > Share a file with download disabled shows an error |
Screenshot
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
juliusknorr
approved these changes
Feb 7, 2023
max-nextcloud
added a commit
that referenced
this pull request
Feb 7, 2023
The collaborator disconnect timeout is in ms as are all intervals. So we can directly subtract it from `Date.now()` - which also is in ms. The only time that is not expressed in ms is the last contact timestamp. Backport of #3769 Signed-off-by: Max <max@nextcloud.com>
4 tasks
max-nextcloud
added a commit
that referenced
this pull request
Feb 7, 2023
The collaborator disconnect timeout is in ms as are all intervals. So we can directly subtract it from `Date.now()` - which also is in ms. The only time that is not expressed in ms is the last contact timestamp. Backport of #3769 Signed-off-by: Max <max@nextcloud.com>
4 tasks
max-nextcloud
added a commit
that referenced
this pull request
Feb 7, 2023
The collaborator disconnect timeout is in ms as are all intervals. So we can directly subtract it from `Date.now()` - which also is in ms. The only time that is not expressed in ms is the last contact timestamp. Backport of #3769 Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
added a commit
that referenced
this pull request
Feb 7, 2023
The collaborator disconnect timeout is in ms as are all intervals. So we can directly subtract it from `Date.now()` - which also is in ms. The only time that is not expressed in ms is the last contact timestamp. Backport of #3769 Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
added a commit
that referenced
this pull request
Feb 8, 2023
The collaborator disconnect timeout is in ms as are all intervals. So we can directly subtract it from `Date.now()` - which also is in ms. The only time that is not expressed in ms is the last contact timestamp. Backport of #3769 Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
added a commit
that referenced
this pull request
Feb 8, 2023
The collaborator disconnect timeout is in ms as are all intervals. So we can directly subtract it from `Date.now()` - which also is in ms. The only time that is not expressed in ms is the last contact timestamp. Backport of #3769 Signed-off-by: Max <max@nextcloud.com>
nextcloud-command
pushed a commit
that referenced
this pull request
Feb 8, 2023
The collaborator disconnect timeout is in ms as are all intervals. So we can directly subtract it from `Date.now()` - which also is in ms. The only time that is not expressed in ms is the last contact timestamp. Backport of #3769 Signed-off-by: Max <max@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This was referenced Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform all computations / comparisons in milliseconds.
The collaborator disconnect timeout is in ms as are all intervals.
So we can directly subtract it from
Date.now()- which also is in ms.The only time that is not expressed in ms is the last contact timestamp.
See also #3741
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)