fix: solve publicly shared document with hide download issue #3765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 flaky tests on run #8777 ↗︎
Details:
|
|||||||||||||||||||||
| Test | ||
|---|---|---|
| Save > saves the actual file and document state |
Screenshot
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
Tests need adjustment |
luka-nextcloud
force-pushed
the
bug/publicly-shared-hide-download-file-issue
branch
from
c677b6a to
1cc006d
Compare
|
/backport to stable25 |
|
@juliushaertl Tests were adjusted - please take a look. |
juliusknorr
reviewed
Feb 8, 2023
luka-nextcloud
force-pushed
the
bug/publicly-shared-hide-download-file-issue
branch
2 times, most recently
from
9c37c45 to
8362640
Compare
juliusknorr
requested changes
Feb 22, 2023
luka-nextcloud
force-pushed
the
bug/publicly-shared-hide-download-file-issue
branch
from
8362640 to
6109c3c
Compare
Signed-off-by: Luka Trovic <luka@nextcloud.com>
luka-nextcloud
force-pushed
the
bug/publicly-shared-hide-download-file-issue
branch
from
313fa90 to
e2dda27
Compare
|
@max-nextcloud @juliushaertl It's all done now. :) |
juliusknorr
approved these changes
Feb 28, 2023
delete-merged-branch
bot
deleted the
bug/publicly-shared-hide-download-file-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luka Trovic luka@nextcloud.com
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)