test: retry failed cypress tests twice #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://dashboard.cypress.io/projects/hx9gqy/runs/4319/test-results/b476bae3-44e3-4184-9d68-81c968f8875a image test retry failing because on the second and third run it has a file conflict. |
max-nextcloud
force-pushed
the
test/retry-failed-cypress-tests
branch
from
785adfa to
440c75d
Compare
|
https://dashboard.cypress.io/projects/hx9gqy/runs/4319/test-results/b476bae3-44e3-4184-9d68-81c968f8875a with the file conflict gone it now fails because the file name counter continues to go up even if the images were removed from the file content itself. This makes sense as the editor was not closed in between. |
max-nextcloud
force-pushed
the
test/retry-failed-cypress-tests
branch
from
440c75d to
cde6965
Compare
|
/rebase |
nextcloud-command
force-pushed
the
test/retry-failed-cypress-tests
branch
from
cde6965 to
bd1de5b
Compare
|
/rebase |
This will hopefully make the CI more stable while allowing us to also see which tests are flaky in the cypress ui. Some tests may not be retryable yet. So they will always fail on a second attempt because of remains of a first attempt. We can tackle that on a test by test basis later. Signed-off-by: Max <max@nextcloud.com>
Use a unique filename so retries work on different files. Uploading the existing file again would cause a conflict resulting in retries failing. Signed-off-by: Max <max@nextcloud.com>
vinicius73
force-pushed
the
test/retry-failed-cypress-tests
branch
from
bd1de5b to
9956041
Compare
vinicius73
added
enhancement
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73
pushed a commit
that referenced
this pull request
Jun 30, 2022
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
|
/compile amend |
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
test/retry-failed-cypress-tests
branch
from
19dc1a2 to
62bb1fe
Compare
vinicius73
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully make the CI more stable
while allowing us to also see which tests are flaky
in the cypress ui.
Some tests may not be retryable yet.
So they will always fail on a second attempt because of remains of a first attempt.
We can tackle that on a test by test basis later.
Signed-off-by: Max max@nextcloud.com