Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong display-name property from provisioning getUser response #72

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Fix wrong display-name property from provisioning getUser response #72

merged 1 commit into from
Mar 22, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Mar 22, 2023

☑️ Resolves

In provisioning API getUser and getCurrentUser methods returns display name with a different property name.
In this PR @nextcloud/auth/getCurrentUser tries both properties considering the current name as "legacy".

Related: nextcloud/server#36665

🚧 Tasks

  • Use legacy 'display-name' property as a fallback for display name

@ShGKme
fix: fix wrong display-name property from provisioning getUser response
ba2a2f9 
- Fix: #70
- Related: nextcloud/server#36665

Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
@ShGKme ShGKme added bug Something isn't working 3. to review labels Mar 22, 2023
@ShGKme ShGKme requested a review from nickvergessen March 22, 2023 14:05
@ShGKme ShGKme self-assigned this Mar 22, 2023
nickvergessen
nickvergessen approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue

@nickvergessen nickvergessen added this to the 💙 Next Preview milestone Mar 22, 2023
@nickvergessen nickvergessen merged commit 06d6917 into main Mar 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/70/wrong-display-name branch March 22, 2023 15:08
ShGKme added a commit that referenced this pull request Mar 24, 2023
@ShGKme
release: v0.2.2
936c2b0 
Fixes:
- Fix zoom without SHIFT and by mouse wheel (#77)
- Fix wrong display name in calls and temp messages (#72)
- Fix loosing authentication on notify_push on any ws error caused brute force protection (#76)

Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
@ShGKme ShGKme mentioned this pull request Mar 24, 2023
Merged
@nickvergessen nickvergessen modified the milestones: v0.3.0, v0.2.2 Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@ShGKme ShGKme

Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ShGKme @nickvergessen