Fix conversation switching lag #5084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoambrosini
added
2. developing
bug
enhancement
feature: frontend 🖌️
marcoambrosini
force-pushed
the
fix-conversation-switch-lag
branch
from
d024ec0 to
85f5e54
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
marcoambrosini
force-pushed
the
fix-conversation-switch-lag
branch
from
85f5e54 to
0983e5e
Compare
marcoambrosini
changed the title
marcoambrosini
force-pushed
the
fix-conversation-switch-lag
branch
2 times, most recently
from
c2a3ce7 to
d4f216f
Compare
marcoambrosini
force-pushed
the
fix-conversation-switch-lag
branch
from
d4f216f to
3a14ec2
Compare
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
marcoambrosini
force-pushed
the
fix-conversation-switch-lag
branch
from
3a14ec2 to
3748a6b
Compare
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
|
Ping @nickvergessen |
|
I like how joining feels much faster! Now when there are new messages that haven't been loaded, you see the old state of the message list with "Joining conversation at the bottom". At this point, do we want to also display a placeholder below the existing messages in the place where new messages might appear ? There's a way to find out if there are new messages by checking that the lastMessage id is different. Not sure if that's a good idea though. 😄 |
PVince81
requested changes
Feb 22, 2021
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
PVince81
reviewed
Feb 24, 2021
|
Addressed the disabled state of action here nextcloud-libraries/nextcloud-vue#1724 |
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
|
follow up here to clean up some bits: #5266 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Immediately display messages from the clicked conversation even if not joined yet with the signaling server.
In order to avoid errors, the call button and the newmessagegorm components are disabled while opening the new session.
TODO:
Peek.2021-02-10.17-00.mp4