Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch an event to signal interest in defering the notifications #3744

Conversation

nickvergessen
Copy link
Member

Backportable hack for the biggest issue of #3743

This can be backported easily and when the notifications app is running nextcloud/notifications#651 it will help making everything faster

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants labels Jun 4, 2020
@nickvergessen nickvergessen added this to the 💚 Next Major (20) milestone Jun 4, 2020
@nickvergessen
Copy link
Member Author

/backport to stable19

@nickvergessen
Copy link
Member Author

/backport to stable18

@nickvergessen
Copy link
Member Author

To test:

  1. Also apply the notifications app PR: [stable19] Allow to group push notifications via an event notifications#651
  2. On top of that apply this in the notifications app https://gist.github.com/nickvergessen/8f53db1960b4d4933072b920edcbb74f
  3. Create a conversation with multiple users (the more that have a push notification device assigned the better)
  4. Start a call in that conversation
  5. Check the log file /var/www/data/notifications.log from 2.

Before there was one request to the push proxy per user, now it's 1 per proxy, so should be 1 for everyone. This should be noticeable when comparing the duration

Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (with a dummy push proxy, not a real one, but it should not make any difference) and works 👍

Signed-off-by: Joas Schilling <coding@schilljs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants