Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also bail out when the path is actually null #3157

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Also bail out when the path is actually null #3157

merged 1 commit into from
Mar 26, 2020

Conversation

nickvergessen
Copy link
Member

Apparently this can happen when a external mount was shared
that is later not available anymore

Ref https://help.nextcloud.com/t/nextcloud-talk-kills-nextcloud-after-update-to-v18-0-3/75257

@nickvergessen
Also bail out when the path is actually null
586b227 
Apparently this can happen when a external mount was shared
that is later not available anymore

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review bug feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Mar 25, 2020
@nickvergessen nickvergessen added this to the 💚 Next Major (19) milestone Mar 25, 2020
@nickvergessen nickvergessen requested a review from danxuliu March 25, 2020 18:02
@nickvergessen
Copy link
Member Author

/backport to stable18

danxuliu
danxuliu reviewed Mar 26, 2020
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the bug in Talk, or is it in the external storage?

I have checked and when a local external storage is removed both the fileid and the path are cleared. On the other hand, if it is misconfigured (by changing the source folder to a different local path), both are kept, and the share is seen as not available anyway.

Maybe the issue is that for some external storage removing it does not clear the fileids but it clears the paths?

Anyway, if the bug is in isAccessibleResult it was copied from server, so this should be applied there as well.

Integration test failures do not seem related (create.feature failed in master too, delete.feature run successfully locally).

@nickvergessen
Copy link
Member Author

Is the bug in Talk, or is it in the external storage?

Well I just saw the report in the forum, so dunno and dont care too much. a null path can not be split

Anyway, if the bug is in isAccessibleResult it was copied from server, so this should be applied there as well.

Right, okay

@nickvergessen nickvergessen requested a review from danxuliu March 26, 2020 12:48
@nickvergessen nickvergessen mentioned this pull request Mar 26, 2020
Merged
@nickvergessen nickvergessen merged commit 516e4ed into master Mar 26, 2020
@nickvergessen nickvergessen deleted the bugfix/noid/shared-former-external-mount branch March 26, 2020 13:59
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 26, 2020
Merged
@backportbot-nextcloud
Copy link

backport to stable18 in #3164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

Assignees
No one assigned
Labels
3. to review bug feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings
Projects
None yet
Milestone
v9.0.0-beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @danxuliu