Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FreeBsd Interface parsing #372

Merged
merged 2 commits into from
May 12, 2022
Merged

Fix FreeBsd Interface parsing #372

merged 2 commits into from
May 12, 2022

Conversation

KDederichs
Copy link
Contributor

Should fix #270

@KDederichs KDederichs changed the title Fix FreeBsd Interface parsing in cases that the interface Fix FreeBsd Interface parsing May 5, 2022
KDederichs added 2 commits May 5, 2022 18:13
@KDederichs
Fix FreeBsd Interface parsing in cases that the interface has no spee…
7b7cb97 
…d or mac

Signed-off-by: Kai Dederichs <kai.dederichs@protonmail.com>
@KDederichs
Make test throw when requesting a non-valid interface
f43e5b5 
Signed-off-by: Kai Dederichs <kai.dederichs@protonmail.com>
kesselb
kesselb approved these changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much 🥳

LGTM.

Logic to hide/show elements is a bit confusing. For mac we have a check in settings-template.php to show the mac when available. For speed there is a another block in FreeBSD.php with some defaults when the data is unavailable.

@kesselb kesselb requested a review from come-nc May 11, 2022 21:25
@come-nc
Copy link
Contributor

come-nc commented May 12, 2022

/backport to stable24

@come-nc
Copy link
Contributor

come-nc commented May 12, 2022

/backport to stable23

@come-nc
Copy link
Contributor

come-nc commented May 12, 2022

/backport to stable22

@come-nc come-nc merged commit aadff83 into nextcloud:master May 12, 2022
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 12, 2022
Merged
@tflidd tflidd mentioned this pull request May 14, 2022
Closed
8 tasks
@KDederichs
Copy link
Contributor Author

/backport to stable23

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 17, 2022
Merged
@KDederichs
Copy link
Contributor Author

/backport to stable22

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 17, 2022
Merged
@KDederichs
Copy link
Contributor Author

Guess it ate them the first time

@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@come-nc come-nc come-nc approved these changes

Assignees
No one assigned
Labels
3. to review backport-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing ifconfig output for system info in FreeBSD logs error
4 participants
@KDederichs @come-nc @kesselb @tflidd