Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static call for isUpdateAvailable #125

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Fix static call for isUpdateAvailable #125

merged 1 commit into from
Sep 3, 2018

Conversation

kesselb
Copy link
Collaborator

@kesselb kesselb commented Sep 1, 2018

@kesselb
Fix static call for isUpdateAvailable
c42f171 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
Copy link
Collaborator Author

kesselb commented Sep 1, 2018

I guess that CI 💥 is unrelated to this.

patschi
patschi reviewed Sep 1, 2018
View reviewed changes
Copy link
Member

@patschi patschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on recent NC14 RC2, working for me.

@patschi patschi added this to the Nextcloud 14 milestone Sep 1, 2018
@patschi
Copy link
Member

patschi commented Sep 1, 2018

Thanks for the PR @danielkesselberg! Just waiting for response by @nickvergessen on this, fix is working fine for me.

And yes, the CI errors are not related to this commit. The appinfo part is already fixed as part of PR #126.

@nickvergessen nickvergessen merged commit 6edaae7 into master Sep 3, 2018
@nickvergessen nickvergessen deleted the bugfix/noid/fix-static-call-installed-apps branch September 3, 2018 11:00
@kesselb kesselb mentioned this pull request Sep 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patschi patschi patschi left review comments

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@kesselb @patschi @nickvergessen