Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the token expiration also work for autocasting 0 #9802

Merged
merged 1 commit into from
Jun 9, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Jun 8, 2018

Some bad databases don't respect the default null apprently.
Now even if they cast it to 0 it should work just fine.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Some bad databases don't respect the default null apprently.
Now even if they cast it to 0 it should work just fine.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added this to the Nextcloud 14 milestone Jun 8, 2018
@rullzer rullzer requested review from MorrisJobke and blizzz June 8, 2018 14:22
@MorrisJobke
Copy link
Member

This causes an endless login loop on a handful of instances.

cc @tflidd @rakekniven - we stopped also the updater for now and plan a followup release next week.

@codecov
Copy link

codecov bot commented Jun 8, 2018

Codecov Report

Merging #9802 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #9802      +/-   ##
============================================
- Coverage     51.92%   51.92%   -0.01%     
  Complexity    25768    25768              
============================================
  Files          1635     1635              
  Lines         95426    95426              
  Branches       1308     1308              
============================================
- Hits          49553    49552       -1     
- Misses        45873    45874       +1
Impacted Files Coverage Δ Complexity Δ
...vate/Authentication/Token/DefaultTokenProvider.php 98.03% <100%> (ø) 32 <0> (ø) ⬇️
apps/files_trashbin/lib/Trashbin.php 72.46% <0%> (-0.25%) 136% <0%> (ø)

@MorrisJobke
Copy link
Member

Just to be clear:

This causes an endless login loop on a handful of instances.

That was the bug that this PR fixes ;)

@ali-rahmanian
Copy link

ali-rahmanian commented Jun 11, 2018

I updated my nextcloud to the latest version and it was working fine. Once I log out and wanted to log in again, I faced with log in loop :'(
Cloud you please help me? I found there would be file permission but it did not solve my issue.

@MorrisJobke
Copy link
Member

@ali-rahmanian On which version are you?

@ali-rahmanian
Copy link

@MorrisJobke Nextcloud 13.0.3

@MorrisJobke
Copy link
Member

@ali-rahmanian This is fixed in the upcoming 13.0.4. Either choose the beta channel or wait for later today to receive the update on the stable channel.

@ali-rahmanian
Copy link

@MorrisJobke Good news. Thanks for your help (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants