-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the token expiration also work for autocasting 0 #9802
Conversation
Some bad databases don't respect the default null apprently. Now even if they cast it to 0 it should work just fine. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This causes an endless login loop on a handful of instances. cc @tflidd @rakekniven - we stopped also the updater for now and plan a followup release next week. |
Codecov Report
@@ Coverage Diff @@
## master #9802 +/- ##
============================================
- Coverage 51.92% 51.92% -0.01%
Complexity 25768 25768
============================================
Files 1635 1635
Lines 95426 95426
Branches 1308 1308
============================================
- Hits 49553 49552 -1
- Misses 45873 45874 +1
|
Just to be clear:
That was the bug that this PR fixes ;) |
I updated my nextcloud to the latest version and it was working fine. Once I log out and wanted to log in again, I faced with log in loop :'( |
@ali-rahmanian On which version are you? |
@MorrisJobke Nextcloud 13.0.3 |
@ali-rahmanian This is fixed in the upcoming 13.0.4. Either choose the beta channel or wait for later today to receive the update on the stable channel. |
@MorrisJobke Good news. Thanks for your help (: |
Some bad databases don't respect the default null apprently.
Now even if they cast it to 0 it should work just fine.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl