Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate groups fetch to ocs api #9296

Merged
merged 2 commits into from
Apr 25, 2018
Merged

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 25, 2018

Use our ocs api instead of old group controller legacy in settings

I reformatted the files:
the only real change is:
https://github.com/nextcloud/server/pull/9296/files?w=1

            $.ajax({
                url: OC.linkToOCS('cloud/groups', 2) + 'details',
                dataType: 'json',
                success: function(data) {
                    var results = [];

                    if (data.ocs.data.groups && data.ocs.data.groups.length > 0) {

                        data.ocs.data.groups.forEach(function(group) {
                            if (!options.excludeAdmins || group.id !== 'admin') {
                                results.push({ id: group.id, displayname: group.displayname });
                            }
                        })

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Apr 25, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone Apr 25, 2018
@skjnldsv skjnldsv self-assigned this Apr 25, 2018
@skjnldsv skjnldsv mentioned this pull request Apr 25, 2018
34 tasks
@codecov
Copy link

codecov bot commented Apr 25, 2018

Codecov Report

Merging #9296 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9296      +/-   ##
============================================
+ Coverage     51.93%   51.93%   +<.01%     
  Complexity    25389    25389              
============================================
  Files          1608     1608              
  Lines         95436    95436              
  Branches       1394     1394              
============================================
+ Hits          49563    49564       +1     
+ Misses        45873    45872       -1
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke requested a review from juliusknorr April 25, 2018 09:36
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean the old endpoint can die?

@nickvergessen
Copy link
Member

It does with #8824

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 25, 2018
@MorrisJobke MorrisJobke merged commit 5a4a0ad into master Apr 25, 2018
@MorrisJobke MorrisJobke deleted the migrate-groups-fetch-to-ocs-api branch April 25, 2018 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: settings feature: users and groups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants