-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate groups fetch to ocs api #9296
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Codecov Report
@@ Coverage Diff @@
## master #9296 +/- ##
============================================
+ Coverage 51.93% 51.93% +<.01%
Complexity 25389 25389
============================================
Files 1608 1608
Lines 95436 95436
Branches 1394 1394
============================================
+ Hits 49563 49564 +1
+ Misses 45873 45872 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean the old endpoint can die?
It does with #8824 |
Use our ocs api instead of old group controller legacy in settings
I reformatted the files:
the only real change is:
https://github.com/nextcloud/server/pull/9296/files?w=1