Move sharing options into popover menu #607

ChristophWurst · 2016-07-27T13:31:34Z

@jancborchardt your turn, fix the styling :-P

TODO:

'Unshare' button does not work. The event is not propagated to the registered event handler, no clue why cc @nextcloud/javascript
with files, the 'can edit' checkbox can only be unchecked. If it's set again then some logic unsets it magically 😩

cc @nextcloud/designers

mention-bot · 2016-07-27T13:31:36Z

@ChristophWurst, thanks for your PR! By analyzing the annotation information on this pull request, we identified @PVince81, @blizzz and @schiessle to be potential reviewers

schiessle · 2016-07-27T13:52:09Z

having this new drop-down menu for the additional share permissions looks great. But I would keep the "unshare" button out. This makes it way more easier to unshare multiple files in a row.

rullzer · 2016-07-27T14:12:52Z

Awesome!
But I agree with @schiessle for the unshare button.

rullzer · 2016-07-27T14:13:15Z

Btw why is can edit not in the dropdown?

ChristophWurst · 2016-07-27T14:25:44Z

Btw why is can edit not in the dropdown?

Because it's used more frequently according to @jancborchardt

MorrisJobke · 2016-07-27T14:56:00Z

Because it's used more frequently according to @jancborchardt

And it is a meta permission. Can edit includes all the other ones, right?

rullzer · 2016-07-27T15:06:38Z

can edit does not cover can share...

jancborchardt · 2016-07-27T19:34:40Z

»can edit« is outside of the dropdown because deciding if you share something with a person read-only or with full access is arguably an important decision. It should not be hidden away in a dropdown.

Agree that we can keep the »Unshare« button out of the dropdown for now. So it should look like this:

😎 Hans           [ ] can edit  •••  🗑

😃 Maria          [x] can edit  •••  🗑

jancborchardt · 2016-07-27T19:35:42Z

What we should also do:

Sort people with most permissions up top (those with edit rights)
rename »can share« to »can reshare« so it’s more clear

rullzer · 2016-07-28T12:09:40Z

I think the can reshare should also be out of the dropdown. It is an essential permission.

rullzer · 2016-08-10T08:27:32Z

Ah it is because of some of the js magic. Let me fix it :)

rullzer · 2016-08-10T09:07:23Z

Should work now ;)

Some things:

Can we move the ... and trash icon all the way to the right?
Can we make the menu appear on the dots?

rullzer · 2016-08-19T11:10:52Z

It now looks like this. Which I think is very nice!
Only thing I really dislike here is the trashbin next to the dot menu... way to easy to click on it....

@jancborchardt suggestions?

MorrisJobke · 2016-08-19T15:18:09Z

Only thing I really dislike here is the trashbin next to the dot menu... way to easy to click on it....

And the alignment is a bit off.

rullzer · 2016-08-24T06:44:42Z

From #146

~~Rename edit to upload and edit~~

Never mind was for link sharing

rullzer · 2016-08-24T06:45:06Z

@MorrisJobke yeah I leave all that to somebody with a bit more CSS fu ;)

jancborchardt · 2016-08-24T08:53:16Z

Only thing I really dislike here is the trashbin next to the dot menu... way to easy to click on it....

@rullzer ;D exactly the reason why I would have moved it into the menu. ;) But a bit of spacing might take care of it as well.

MorrisJobke · 2016-08-30T07:01:20Z

@ChristophWurst @rullzer What is the status of this? Could I somehow help here?

rullzer · 2016-08-30T07:47:26Z

@MorrisJobke ah yes. The aligning is still a bit off and we probabaly need more spacing between the delete button.

Awesome if you could take care :)

ChristophWurst · 2016-09-24T15:03:14Z

@MorrisJobke @rullzer what's the status of this now? Anything left that needs to be done?

MorrisJobke · 2016-09-26T15:21:40Z

@MorrisJobke @rullzer what's the status of this now? Anything left that needs to be done?

Rullzer asked if I could help with the layout. I haven't looked at it yet.

ChristophWurst · 2016-10-03T07:35:38Z

Fixed the alignment and added some padding to the unshare icon:

rullzer · 2016-10-03T10:22:22Z

@ChristophWurst thnx!

I'd say lets get this in! We can sort out details later. Longer we wait the more conflicts and stuff will pop up.

SO LGTM!

codecov-io · 2016-10-03T10:41:29Z

Current coverage is 30.59% (diff: 100%)

Merging #607 into master will not change coverage

@@             master       #607   diff @@
==========================================
  Files          1081       1081          
  Lines         60020      60020          
  Methods        6808       6808          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          18362      18362          
  Misses        41658      41658          
  Partials          0          0

Powered by Codecov. Last update 07a1be2...96af627

LukasReschke · 2016-10-03T12:18:12Z

LGTM

LukasReschke · 2016-10-03T12:18:52Z

@ChristophWurst FYI https://github.com/nextcloud/server/blob/master/CONTRIBUTING.md#sign-your-work

ChristophWurst added enhancement 2. developing Work in progress feature: sharing labels Jul 27, 2016

ChristophWurst added this to the Nextcloud 11.0 milestone Jul 27, 2016

ChristophWurst assigned jancborchardt Jul 27, 2016

rullzer force-pushed the sharing-popover-menu branch 3 times, most recently from 483ede9 to cbf0a65 Compare August 10, 2016 09:01

rullzer force-pushed the sharing-popover-menu branch from cbf0a65 to 098460f Compare August 19, 2016 11:09

rullzer added the design Design, UI, UX, etc. label Aug 24, 2016

rullzer mentioned this pull request Aug 24, 2016

The 'edit' option for folders should be 'upload and edit' #146

Closed

MorrisJobke self-assigned this Aug 30, 2016

rullzer mentioned this pull request Sep 6, 2016

Display link reshares #1114

Merged

blizzz mentioned this pull request Sep 20, 2016

Signature Panel #1213

Closed

9 tasks

ChristophWurst and others added 5 commits October 3, 2016 09:06

move sharing options into popover menu

1181ac1

move unshare button out of popover menu; keep menu opened on re-render

7533fcb

Make can edit checkbox work for file shares

5cda383

can share => can reshare

e343d6f

Move options to the right

092eae4

fix sharing icon's alignment and add padding to the unshare icon

96af627

ChristophWurst force-pushed the sharing-popover-menu branch from 098460f to 96af627 Compare October 3, 2016 07:36

ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 3, 2016

LukasReschke merged commit 08b0e5c into master Oct 3, 2016

LukasReschke deleted the sharing-popover-menu branch October 3, 2016 12:18

MorrisJobke removed their assignment Oct 6, 2016

gisforgirard mentioned this pull request Feb 19, 2021

[Snyk] Upgrade v-tooltip from 2.0.3 to 2.1.2 gisforgirard/server#16

Open

snyk-bot mentioned this pull request Apr 16, 2021

[Snyk] Upgrade v-tooltip from 2.0.3 to 2.1.3 chankoba/server#2

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move sharing options into popover menu #607

Move sharing options into popover menu #607

ChristophWurst commented Jul 27, 2016 •

edited by rullzer

Loading

mention-bot commented Jul 27, 2016

schiessle commented Jul 27, 2016

rullzer commented Jul 27, 2016

rullzer commented Jul 27, 2016

ChristophWurst commented Jul 27, 2016

MorrisJobke commented Jul 27, 2016

rullzer commented Jul 27, 2016

jancborchardt commented Jul 27, 2016

jancborchardt commented Jul 27, 2016 •

edited by rullzer

Loading

rullzer commented Jul 28, 2016

rullzer commented Aug 10, 2016

rullzer commented Aug 10, 2016 •

edited

Loading

rullzer commented Aug 19, 2016

MorrisJobke commented Aug 19, 2016

rullzer commented Aug 24, 2016 •

edited

Loading

rullzer commented Aug 24, 2016

jancborchardt commented Aug 24, 2016

MorrisJobke commented Aug 30, 2016

rullzer commented Aug 30, 2016

ChristophWurst commented Sep 24, 2016

MorrisJobke commented Sep 26, 2016

ChristophWurst commented Oct 3, 2016

rullzer commented Oct 3, 2016

codecov-io commented Oct 3, 2016

LukasReschke commented Oct 3, 2016

LukasReschke commented Oct 3, 2016

Move sharing options into popover menu #607

Move sharing options into popover menu #607

Conversation

ChristophWurst commented Jul 27, 2016 • edited by rullzer Loading

mention-bot commented Jul 27, 2016

schiessle commented Jul 27, 2016

rullzer commented Jul 27, 2016

rullzer commented Jul 27, 2016

ChristophWurst commented Jul 27, 2016

MorrisJobke commented Jul 27, 2016

rullzer commented Jul 27, 2016

jancborchardt commented Jul 27, 2016

jancborchardt commented Jul 27, 2016 • edited by rullzer Loading

rullzer commented Jul 28, 2016

rullzer commented Aug 10, 2016

rullzer commented Aug 10, 2016 • edited Loading

rullzer commented Aug 19, 2016

MorrisJobke commented Aug 19, 2016

rullzer commented Aug 24, 2016 • edited Loading

rullzer commented Aug 24, 2016

jancborchardt commented Aug 24, 2016

MorrisJobke commented Aug 30, 2016

rullzer commented Aug 30, 2016

ChristophWurst commented Sep 24, 2016

MorrisJobke commented Sep 26, 2016

ChristophWurst commented Oct 3, 2016

rullzer commented Oct 3, 2016

codecov-io commented Oct 3, 2016

Current coverage is 30.59% (diff: 100%)

LukasReschke commented Oct 3, 2016

LukasReschke commented Oct 3, 2016

ChristophWurst commented Jul 27, 2016 •

edited by rullzer

Loading

jancborchardt commented Jul 27, 2016 •

edited by rullzer

Loading

rullzer commented Aug 10, 2016 •

edited

Loading

rullzer commented Aug 24, 2016 •

edited

Loading