-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use absolute urls in SCSS #5137
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @schiessle and @nickvergessen to be potential reviewers. |
We can also have one cache per domain... |
That would be pretty bad, since then we would need to store an individual cached css file for each domain as well.
Not sure about that, I remember some issues with Nextcloud not running in root but I've tested that with the proposed changes and it works as well. |
Hmm is it possible that the problem is when two urls use a different subpath (folder)? |
@nickvergessen Is that something that is possible to configure? So to summarize we can have one Nextcloud instance that can be accessed by the following set of URLs: Is there anything missing? So i guess we should cache scss files then for each of this combinations of server host and subdirectories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and still works 👍
Absolute urls will not work with multiple trusted domains, since they are cached here.
Fix for #5085