Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Deprecate OC_Template, add proper template manager instead #51029

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

fix: Deprecate OC_Template, add proper template manager instead #51029

wants to merge 9 commits into from

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Feb 25, 2025 •
edited
Loading

Summary

Adds a proper manager with an interface for templates.
Deprecate legacy OC_Template as well as \OCP\Template class which was used as a public constructor.

TODO

  • ITemplate interface with needed methods
  • Remove all calls to OC_Template
  • Remove all calls to OCP\Template
  • follow-up: figure out what to do helper methods/functions
  • cleanup horrible TemplateLayout
  • follow-up: move OC_Util::scripts/styles/headers to template manager

Checklist

@come-nc come-nc added the 2. developing Work in progress label Feb 25, 2025
@come-nc come-nc self-assigned this Feb 25, 2025
@come-nc come-nc force-pushed the fix/deprecate-oc-template-and-cleanup branch from 0573048 to ddc5106 Compare February 27, 2025 13:05
@susnux susnux added this to the Nextcloud 32 milestone Mar 2, 2025
@come-nc come-nc force-pushed the fix/deprecate-oc-template-and-cleanup branch 2 times, most recently from 3eee02b to 836da41 Compare March 3, 2025 09:50
come-nc added 9 commits March 3, 2025 14:34
@come-nc
fix: Deprecate OC_Template, add proper template manager instead
d90b614 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix: Add missing ITemplate interface and clean code in Template class
5765474 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix: Fix psalm issues and add missing methods to ITemplate interface
9dad0e4 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix: Replace all usage of OC_Template by the new API
4a65a41 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix: Fix signatures and types in template related classes
21094e2 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix: Cleanup of internal class TemplateLayout
aea0153 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
chore: Adapt TemplateLayout tests
abb58dc 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix: Migrate all uses of OCP\Template to OCP\Template\ITemplateManager
3f6da8f 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix: Remove legacy hacky workaround in OCA\WorkflowEngine\Listener
960b2b5 
It is not needed anymore since OCP\Util::addScript is used directly now,
 and not the function "script" from template functions.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/deprecate-oc-template-and-cleanup branch from 8d9a88c to 960b2b5 Compare March 3, 2025 13:34
@come-nc come-nc marked this pull request as ready for review March 3, 2025 13:54
@come-nc come-nc added 3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update and removed 2. developing Work in progress labels Mar 3, 2025
@come-nc
Copy link
Contributor Author

come-nc commented Mar 3, 2025

CI failure unrelated

@come-nc come-nc requested a review from susnux March 3, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala is a code owner

@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner

@st3iny st3iny Awaiting requested review from st3iny st3iny is a code owner

@susnux susnux Awaiting requested review from susnux

At least 2 approving reviews are required to merge this pull request.

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.
2 participants
@come-nc @susnux