Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable31] feat(files): allow to ignore warning to change file type #51015

Open
wants to merge 1 commit into
base: stable31
Choose a base branch
from
Open

[stable31] feat(files): allow to ignore warning to change file type #51015

wants to merge 1 commit into from
+455 −180

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 25, 2025 •
edited by susnux
Loading

Backport of #50979

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added this to the Nextcloud 31.0.1 milestone Feb 25, 2025
@susnux
feat(files): allow to ignore warning to change file type
ce70a14 
* Missing pieces of #46528
  * Add checkbox to not show this dialog again
  * Add user config as suggested by designers in files settings to
    reenable or diable this behavior.
  * Fix behavior of dialog: It says "keep .ext" but it does not keep the
    extension but cancels the operation. From the button label the user
    expects that the operation is continued but with the old extension.
  * Added more test coverage by adding component tests.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the backport/50979/stable31 branch from 9a0eb18 to ce70a14 Compare March 3, 2025 13:22
@susnux susnux marked this pull request as ready for review March 3, 2025 13:22
@susnux susnux requested a review from skjnldsv as a code owner March 3, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Pytal Pytal Pytal approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees

@susnux susnux

Labels
3. to review Waiting for reviews enhancement 🍀 2025-Spring
Projects
None yet
Milestone
Nextcloud 31.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @Pytal