-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(object_store): Add support for session token (STS) in AWS credentials #50702
feat(object_store): Add support for session token (STS) in AWS credentials #50702
Conversation
- Pass session token, either null or with value, to the AWS Credentials constructor Signed-off-by: Hector Valcarcel <hmvalcarcel@gmail.com>
fcea40d
to
6b4c859
Compare
I wonder what it'd take to add an integration test for this... 🤔 https://min.io/docs/minio/linux/developers/security-token-service.html |
How does the expiration/rotation of STS credentials work here given that the Nextcloud use case for S3 is ongoing not temporary? |
@joshtrichards that could be an interesting step. However, I would recommend trying a different direction for the integration tests, something like a combination of:
then you can manage all the outside platforms directly via code 😉 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough about S3 to judge the use case, but the code itself seems fine
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Summary
Support using a Session Token for temporal AWS Credentials
Checklist