fix: automatically disable sab

[SebastianKrupinski]

• Resolves: Automatically disable the system address book for large instances #49431

Summary

Automatically disables system address book when a configured limit is reached.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[ChristophWurst]

Looks good

[SebastianKrupinski]

/backport to stable31

[SebastianKrupinski]

/backport to stable30

[SebastianKrupinski]

/backport to stable29

[st3iny]

Looks good and tests are included.

[SebastianKrupinski]

@st3iny thank you

[SebastianKrupinski]

Temporarily converted to draft to adjust logic.

[st3iny]

Temporarily converted to draft to adjust logic.

What is the problem? The sync being run despite the exposed config being set to no?

[kesselb]

What is the problem?

The code is only executed when running the sync command via occ or when installing nextcloud (but then you don't have a 5k user directory connected). It should be a migration / repair step to automatically disable sab. Not as side effection when calling the sync command.

[SebastianKrupinski]

What is the problem? The sync being run despite the exposed config being set to no?

No... at the moment the logic disables the system address book automatically even if the admin forces the "system_addressbook_exposed" to yes, if the limit is reached. And during our 1 on 1 today, we thought that is might cause confusion. So the solution is to only automatically disable the address book if the "system_addressbook_exposed" has not been set yet, I just have not made the adjustment yet.

[st3iny]

Daniel is right though. The syncInstance() method is only called from the occ command (or during an old migration).