Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for moving a file from and to a shared folder #50221

Conversation

danxuliu
Copy link
Member

(Turns out that back in the day I made the commit, wrote the pull request description in a local file... and then forgot to open the pull request 🤦 Sorry about that.)

This pull request adds some integration tests that should have exposed the regression introduced in bd740ac (and fixed in #47986 (comment)) when run on CI, as dav_features/webdav-related.feature are also run with S3 as primary storage.

@danxuliu danxuliu added 3. to review Waiting for reviews tests Related to tests labels Jan 17, 2025
@danxuliu danxuliu added this to the Nextcloud 31 milestone Jan 17, 2025
@provokateurin
Copy link
Member

PR with only tests 😍

This was referenced Jan 21, 2025
…lder

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@artonge artonge force-pushed the add-integration-tests-for-moving-a-file-from-and-to-a-shared-folder branch from 7aadfed to b59c71c Compare January 27, 2025 13:13
@artonge
Copy link
Contributor

artonge commented Jan 27, 2025

Rebased

@provokateurin provokateurin merged commit 2f862d1 into master Jan 27, 2025
142 checks passed
@provokateurin provokateurin deleted the add-integration-tests-for-moving-a-file-from-and-to-a-shared-folder branch January 27, 2025 16:03
@AndyScherzinger
Copy link
Member

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews tests Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants