feat(Navigation): emit dedicated event for loading additional entries #49904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, apps that add custom/dynamic entries have to listen to the
BeforeTemplateRenderedEvent
when they intend to add navigation entries. This is already rather a hack and relies on template rendering.But there is the endpoint of the NavigationController in core that offers to get the current data of the app navigation. The app management is making use of it, and Tables would like to do so too. But in this code path, the above mentioned Event is not being fired. Hence, fire a dedicated event.
This is a grey zone between a feature and a bug. For the other use case in tables we can work around it with an own endpoint, for the app management this can be considered a bug, and solving it would require the change to be backported. It would not be breaking. Since it is nowhere critical I am fine having it for 31 only.
Screenrecording of the problem:
Screencast_20241217_202733.webm
With this change and modified tables app:
Screencast_20241217_202922.webm
Checklist