Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix username and avatar for external users #4969

Merged
merged 1 commit into from
May 23, 2017
Merged

Fix username and avatar for external users #4969

merged 1 commit into from
May 23, 2017

Conversation

nickvergessen
Copy link
Member

Fix nextcloud/activity#155

Steps

  1. Share a folder as public link
  2. As a visitor of the link create a folder and upload a file
  3. As visitor of the link move the file into the folder
  4. As link owner open your activity stream

Expected:

"remote user" moved aviatorjk_2112.jpg to test

Actual

activity_-nextcloud-_2017-05-19_15 48 59

@nickvergessen
Fix username and avatar for external users
edb4956 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 13 milestone May 19, 2017
@nickvergessen
Copy link
Member Author

Would backport for 12.0.1 only, not important enough...

MorrisJobke
MorrisJobke approved these changes May 19, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@rullzer rullzer merged commit 3aee260 into master May 23, 2017
@rullzer rullzer deleted the fix-broken-activity-avatars-with-external-users branch May 23, 2017 06:33
@nickvergessen nickvergessen mentioned this pull request May 23, 2017
Merged
@ChristophWurst ChristophWurst mentioned this pull request Mar 4, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: activity and notification feature: sharing
Projects
None yet
Milestone
Nextcloud 13
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @rullzer @MorrisJobke