fix(settings): Sort all settings - incl declarative settings - by priority #48424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
artonge,
provokateurin,
a team and
icewind1991
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private function formatSettings(array $settings, array $declarativeSettings): array { | ||
| $settings = array_merge($settings, $declarativeSettings); | ||
|
|
||
| usort($settings, function ($first, $second) { |
Check notice
Code scanning / Psalm
MissingClosureReturnType Note
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…ority Previously declarative settings were sorted by priority but behind the "native" settings, this is now fixed, meaning a declarative setting with higher priority than an `ISetting` will be correctly rendered before that `ISetting` in the settings list. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/declarative-settings-priority
branch
from
63b4c5c to
b525618
Compare
provokateurin
approved these changes
Sep 28, 2024
SebastianKrupinski
approved these changes
Sep 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously declarative settings were sorted by priority but behind the "native" settings, this is now fixed, meaning a declarative setting with higher priority than an
ISettingwill be correctly rendered before thatISettingin the settings list.Checklist