Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i18n): Spelling of ID #47808

Merged
merged 1 commit into from
Sep 7, 2024
Merged

chore(i18n): Spelling of ID #47808

merged 1 commit into from
Sep 7, 2024

Conversation

rakekniven
Copy link
Member

Reported at Transifex

Reported at Transifex

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
@rakekniven
Copy link
Member Author

Hello @joshtrichards , why adding milestone NC31?
This could be easily adapted for NC30.0.1, or?

@susnux
Copy link
Contributor

susnux commented Sep 7, 2024

why adding milestone NC31?

Because every PR against master is milestone 31 or later, of course a backport for stable30 is possible, then that backport PR will target milestone 30.0.x

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, though should have been never translated

@susnux susnux merged commit 1c52bd7 into master Sep 7, 2024
174 checks passed
@susnux susnux deleted the rakekniven-patch-2 branch September 7, 2024 12:06
@susnux
Copy link
Contributor

susnux commented Sep 7, 2024

@rakekniven the PR introducing this strings was not yet backported to 30, no backport atm

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants