Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files_sharing): password checkbox and labels in link share #47807

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Sep 6, 2024

Summary

In link share creation:

  • When "Always ask for a password" is enabled but not enforced, there was no checkbox to enable/disable password
    • NcActionCheckbox component wasn't imported and registered - fixed
  • In both password and date inputs, there were no labels but just a text in the previous item
    • NcActionInput content was used instead of a label prop - replaced
    • Also, removed unneeded NcActionText in flavor of label

Screenshots

Enforced date - worked but no accessible label

Before After
image image

Enforced password - worked but no accessible label

Before After
image image

Ask for a password - had no label at all and no checkbox to re-enable

Before After
before-password after-password

Checklist

@ShGKme ShGKme added this to the Nextcloud 31 milestone Sep 6, 2024
@ShGKme ShGKme self-assigned this Sep 6, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Sep 6, 2024

/backport to stable30

@ShGKme
Copy link
Contributor Author

ShGKme commented Sep 6, 2024

/backport to stable29

@ShGKme ShGKme requested review from nfebe, susnux and skjnldsv and removed request for susnux September 6, 2024 15:11
@ShGKme ShGKme requested a review from artonge September 9, 2024 09:03
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/files_sharing--password-label branch from c6be59f to 692a8ed Compare September 9, 2024 13:03
@ShGKme
Copy link
Contributor Author

ShGKme commented Sep 9, 2024

Rebased on master to resolve conflicts.

@ShGKme ShGKme enabled auto-merge September 9, 2024 13:03
@ShGKme ShGKme merged commit 4e68e88 into master Sep 9, 2024
116 checks passed
@ShGKme ShGKme deleted the fix/files_sharing--password-label branch September 9, 2024 14:41
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants