Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #30551: Added snowfall option to weather status line 101 #47702

Closed

Conversation

XxTysweezyxX
Copy link
Contributor

@XxTysweezyxX XxTysweezyxX commented Sep 3, 2024

Summary

TODO

  • ...

Checklist

@AndyScherzinger AndyScherzinger added this to the Nextcloud 31 milestone Sep 3, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@julien-nc
Copy link
Member

Hey @XxTysweezyxX . Thanks a lot for starting this. I checked the code and started adding stuff on top. I ended up making a way larger PR around your changes. It's there #48353 . I hope you don't mind.

The issue with your changes was that the weather code you used for snow are not the ones api.met.no can return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[weather_status] Snowfall
3 participants