Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DB): set sharding parameters only when intended #47611

Merged
merged 4 commits into from
Aug 29, 2024
Merged

fix(DB): set sharding parameters only when intended #47611

merged 4 commits into from
Aug 29, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Aug 29, 2024

Summary

32bit setup fails to due to AutoIncrementHandler

Checklist

blizzz added 2 commits August 29, 2024 19:12
@blizzz
fix(DB): set sharding parameters only when intended
381e922 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
build: bump version to force 32bit test
79b34aa 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added bug 3. to review Waiting for reviews labels Aug 29, 2024
@blizzz blizzz requested review from artonge, sorbaugh, come-nc and a team August 29, 2024 17:17
AndyScherzinger
AndyScherzinger approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliusknorr
juliusknorr approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@blizzz
Copy link
Member Author

blizzz commented Aug 29, 2024

More complicated, as \OC\DB\Connection does initialize them anyway, does not consider the dbsharding flag and assume it is always set up.

@blizzz
Copy link
Member Author

blizzz commented Aug 29, 2024 •
edited
Loading

More complicated, as \OC\DB\Connection does initialize them anyway, does not consider the dbsharding flag and assume it is always set up.

ah, partly because the configkey is misspelled there… $shardConfig = $this->params['sharding'] ?? [];.

Someone should invent constants 🤪

UPDATE: PEBCAK 🤪

@blizzz
Copy link
Member Author

blizzz commented Aug 29, 2024

@juliushaertl if you could throw another eyeball on the new commit 🙇

@AndyScherzinger
Copy link
Member

Second commit also looks good to me 👍 @blizzz

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 29, 2024
View reviewed changes
@blizzz
fix(DB): do not assume sharding is always enabled
edaa4d1 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the fix/noid/no-sharding-32 branch from 0005ec0 to edaa4d1 Compare August 29, 2024 17:56
@blizzz blizzz mentioned this pull request Aug 29, 2024
Merged
@blizzz
test(phpunit): skip sharding tests on 32bit
b71c539 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@juliusknorr
Copy link
Member

Also looks good 👍

@blizzz blizzz merged commit 4accba8 into master Aug 29, 2024
175 of 176 checks passed
@blizzz blizzz deleted the fix/noid/no-sharding-32 branch August 29, 2024 18:49
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@sorbaugh sorbaugh sorbaugh approved these changes

@artonge artonge Awaiting requested review from artonge

@come-nc come-nc Awaiting requested review from come-nc

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blizzz @AndyScherzinger @juliusknorr @sorbaugh