Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webhook_listeners): Enable the app by default #47532

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Aug 27, 2024

  • Resolves: #

Summary

Enable the app webhook_listeners by default.

Checklist

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added the 3. to review Waiting for reviews label Aug 27, 2024
@come-nc come-nc added this to the Nextcloud 31 milestone Aug 27, 2024
@come-nc come-nc self-assigned this Aug 27, 2024
@come-nc
Copy link
Contributor Author

come-nc commented Aug 27, 2024

/backport to stable30

@AndyScherzinger
Copy link
Member

I am fine either way, but didn't we decide to not enable it by default?

@bigcat88
Copy link
Member

We have similar functionality in AppAPI, and in order not to duplicate it, we plan to deprecate a more truncated copy of this functionality in AppAPI and use the webhooks_listeners application for this, which is written much better.

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@AndyScherzinger AndyScherzinger merged commit 3a565b3 into master Aug 28, 2024
113 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/default-enable-webhooks branch August 28, 2024 18:45
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants