fix(ShareEntryLinkedList): Correctly propagate share data #45828
Conversation
`this.shares.unshift` mutates the share object for every component that uses the share mixin. Using the immutable approach changes the array reference which makes the mixin lose track of the share object. It would have been better to bubble up the share object but here we are :) Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
this.shares.unshiftmutates the share object for every component that uses the share mixin.Using the immutable approach changes the array reference which makes the mixin lose track of the share object.
It would have been better to bubble up the share object but here we are :)