Remove asset pipelin #418
Remove asset pipelin #418
Conversation
Fixes #215 The asset pipeline has shown to do more harm than good. Some apps fail hard with it. Also it makes sure that you download a huge file on each unvisited page.
| $this->append( 'jsfiles', \OC::$server->getURLGenerator()->linkToRoute('js_config', ['v' => self::$versionHash])); | ||
| $this->generateAssets(); | ||
| } else { |
There was a problem hiding this comment.
Is this else branch only related to assets?
There was a problem hiding this comment.
Yes. See the file before the commit. there is the
if ($useAssetPipeline) {
|
👍 looks good, will probably also need a PR to remove the thirdparty libs, correct? |
|
Yes will fix 3rdparty stuff after this is in. |
|
Tested and works 👍 |
|
Btw do we already have a list of important release highlights/changelog for admins? |
|
The online docs need to get updated too as that had me searching for 30 minutes as to why it wasn't working after my upgrade. The option has been removed from the sample config, but the docs don't. |
|
So, we have release notes, I think it'd be nicer to put that in in the future directly rather than wait. It's just a doc in our documentation repo: https://github.com/nextcloud/documentation/edit/stable11/admin_manual/release_notes.rst - easy to edit. What I don't know is WHAT I should write about this thing in there ;-) Can someone enlighten or, better, edit the document via the link above and just add a bulletpoint somewhere? No need to make it pretty or perfect, that part I can do... |
|
Fixes #215
The asset pipeline has shown to do more harm than good. Some apps fail
hard with it. Also it makes sure that you download a huge file on each
unvisited page.
@LukasReschke as discussed
CC: @MorrisJobke @BernhardPosselt @popov-d @nickvergessen